Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct package name in safe-ethers-adapters #140

Merged
merged 2 commits into from
Jan 10, 2022
Merged

fix: correct package name in safe-ethers-adapters #140

merged 2 commits into from
Jan 10, 2022

Conversation

prestwich
Copy link
Contributor

What it solves

@gnosis.pm/safe-ethers-adapters has a peer dependency on @ethersproject/abstract-providers, which does not exist. This causes an error on installation

> $ npm i @gnosis.pm/safe-ethers-adapters
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @gnosis.pm/[email protected]
npm WARN Found: @ethersproject/abstract-providers@undefined
npm WARN node_modules/@ethersproject/abstract-providers
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @ethersproject/abstract-providers@"^5.0.0" from @gnosis.pm/[email protected]
npm WARN node_modules/@gnosis.pm/safe-ethers-adapters
npm WARN   @gnosis.pm/safe-ethers-adapters@"*" from the root project
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/@ethersproject%2fabstract-providers - Not found
npm ERR! 404 
npm ERR! 404  '@ethersproject/abstract-providers@^5.0.0' is not in this registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

How this PR fixes it

Corrects the package name in package.json.
This will require republishing the package

@github-actions
Copy link

github-actions bot commented Jan 9, 2022 •
edited
Loading

CLA Assistant Lite All Contributors have signed the CLA.

@prestwich
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@prestwich
Copy link
Contributor Author

recheckcla

@prestwich
Copy link
Contributor Author

signing away the rights to a 1-character deletion lmao

@germartinez germartinez changed the base branch from main to development January 10, 2022 09:14
@germartinez
Copy link
Member

Thank you, @prestwich!

The rights have been granted 😄

@germartinez germartinez self-requested a review January 10, 2022 09:18
@germartinez germartinez merged commit bff86c3 into safe-global:development Jan 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@germartinez germartinez germartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @germartinez